Support location message type #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepbluev7
requested changes
Jan 8, 2023
Comment on lines
+184
to
+185
| if (obj.find("xyz.amorgan.blurhash") != obj.end()) | ||
| info.blurhash = obj.at("xyz.amorgan.blurhash").get<std::string>(); |
There was a problem hiding this comment.
I think this is wrong. I think only the thumbnail has a blurhash.
| { | ||
| if (!info.thumbnail_url.empty()) { | ||
| obj["thumbnail_url"] = info.thumbnail_url; | ||
| obj["thumbnail_info"] = info.thumbnail_info; |
There was a problem hiding this comment.
I think this should be serialized when a thumbnail_url or a thumbnail_file is present.
Comment on lines
+197
to
+198
| if (!info.blurhash.empty()) | ||
| obj["xyz.amorgan.blurhash"] = info.blurhash; |
Comment on lines
+313
to
+314
| // events::RoomEvent<events::msg::Location> location = e; | ||
| // container.emplace_back(location); |
There was a problem hiding this comment.
I think you can delete these.
Comment on lines
+413
to
+414
| events::RoomEvent<events::msg::Location> location = e; | ||
| container.emplace_back(location); |
There was a problem hiding this comment.
Can you write that in the style of the lines above, i.e.:
Suggested change
| events::RoomEvent<events::msg::Location> location = e; | |
| container.emplace_back(location); | |
| container.emplace_back(events::RoomEvent<events::msg::Location>(e)); |
1 task
|
@hamzehnasajpour: ping! Are you still planning to finish this? :) |
Unfortunately I was so busy and couldn't update and finish it. Is it possible to fix it by you or someone else? |
|
Somebody should be able to pick it up. Thank you for providing the initial implementation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#87